This repository was archived by the owner on Apr 19, 2026. It is now read-only.
Set x-google-api-name in OpenAPI document.#139
Merged
inklesspen merged 1 commit intocloudendpoints:masterfrom Feb 26, 2018
inklesspen:x-google-api-name
Merged
Set x-google-api-name in OpenAPI document.#139inklesspen merged 1 commit intocloudendpoints:masterfrom inklesspen:x-google-api-name
inklesspen merged 1 commit intocloudendpoints:masterfrom
inklesspen:x-google-api-name
Conversation
This allows combining multiple APIs with different names into the same service. API names must now match a regular expression; they can consist of up to 40 lowercase letters and numbers, except that the first character must be a lowercase letter.
kryzthov
approved these changes
Feb 24, 2018
|
|
||
| def _CheckApiName(name): | ||
| valid = (_VALID_API_NAME.match(name) is not None) | ||
| if not valid: |
There was a problem hiding this comment.
nit: maybe compact to if not _VALID_API_NAME.match(name)?
Contributor
Author
There was a problem hiding this comment.
PEP8 recommends being explicit about checking if a value is None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows combining multiple APIs with different names into the same
service. API names must now match a regular expression; they can
consist of up to 40 lowercase letters and numbers, except that the
first character must be a lowercase letter.
Fixes #47, fixes #74.